Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

[Darwin] Disable NSAsserts in release builds.#860

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
bc-lee:feature/disable-nsassert
May 23, 2024
Merged

[Darwin] Disable NSAsserts in release builds.#860
auto-submit[bot] merged 1 commit intoflutter:masterfrom
bc-lee:feature/disable-nsassert

Conversation

@bc-lee
Copy link
Copy Markdown
Contributor

@bc-lee bc-lee commented May 17, 2024

Chromium has a similar gn flag to disable asserts in release builds: https://source.chromium.org/chromium/chromium/src/+/main:build/config/BUILD.gn;drc=9dab28144192cefadbb96b778ef866ea3deb74ff;l=148

Related: flutter/flutter#148279

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Loading
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants